add pattern blame

[Glease]

so you know who was that idiot adding broken pattern
Closes GTNewHorizons/GT-New-Horizons-Modpack#14297

[github-actions]

Warning: 2 uncommitted changes
#399

[Rika-TH]

Perfection, keep whoever makes the bad ones in charge of AE to get updoots 👍

[JodieRuth]

Kick this idiot out of the server

[firenoo]

Resolve regardless of action taken before merging

[Glease]

we have discovered a subtle problem with the implementation. if there were two different people encoded the same recipe (or a recipe with no encoder information), they will be treated as two different pattern, and AE won't load balance between the two. I have come up with a solution of preprocessing the item used for equality check in PatternHelper, but I'm not sure if this is worth it (as copying an NBT can be expensive)

stale

[firenoo]

Why not change PatternHelper to check only input/output stack nbt matches instead of full copy? Preferrably cache equivalent patterns

[Glease]

well AE2 has a shared NBT cache, so it'd actually be faster to compare full stack (which is just a == check between the two NBT tag) than to compare by indiviual inputs (which will need to iterate over every inputs and go into every subtag the inputs/outputs have)

[firenoo]

PatternHelper usages needs to be cleaned up anyways as its instantiated way too often so I think its fine the way you implemented it (with those patches)

[Glease]

we will see how much of a performance impact this has