Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Deprecate and remove usages of GridCacheWrapper #650

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

szuend
Copy link

@szuend szuend commented Jan 1, 2025

The GridCacheWrapper is a simple wrapper around an arbitrary IGridCache plus storing the name of the IGridCache. Since the name is actually unused, we can get rid of the wrapper altogether and just use the IGridCache directly.

@Dream-Master Dream-Master requested a review from a team January 1, 2025 14:08
@szuend szuend force-pushed the nuke-grid-wrapper branch from bc7961d to 0746271 Compare January 1, 2025 14:40
@szuend szuend changed the title cleanup: Remove GridCacheWrapper cleanup: Deprecate and remove usages of GridCacheWrapper Jan 1, 2025
@serenibyss serenibyss dismissed boubou19’s stale review January 3, 2025 02:28

resolved in latest commit

@serenibyss serenibyss merged commit ae8a1b1 into GTNewHorizons:master Jan 3, 2025
1 check passed
michaeldoylecs pushed a commit to michaeldoylecs/Applied-Energistics-2-Unofficial that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants