Misc. interconnected meteor loose ends and code cleanup #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrote the meteor config read function to use a TypeAdapter for the Meteor Components, which made the distinction between Meteor.java and MeteorParadigm.java redundant. MeteorParadigm.java was renamed to Meteor.java, and the methods in the old Meteor.java were moved. Moved many methods in Meteor.java were moved out to other classes where they were more relevant. Made fillerChance in Meteor.java a float to allow greater control over configuration. Moved some hard-coded default values to the BM config file. Created default meteor configs that will be generated if config/BloodMagic/meteors/ is not present. Improved default config generation by making some code in AlchemicalWizardry.java used to load default schematics a generic function. Created some README files that will be generated only if config/BloodMagic/meteors/ or config/BloodMagic/meteors/reagents is not present. Refactored many files related to meteors to remove the word "Paradigm" because it just served to make names longer.
OneEyeMaker
requested changes
Jan 20, 2025
src/main/java/WayofTime/alchemicalWizardry/BloodMagicConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/WayofTime/alchemicalWizardry/common/summoning/meteor/Meteor.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the meteor config read method to use a TypeAdapter for the Meteor Components, which made the distinction between Meteor.java and MeteorParadigm.java redundant.
MeteorParadigm.java was renamed to Meteor.java, and the methods in the old Meteor.java were moved. Many methods previously in MeteorParadigm.java were moved out to other classes where they were more relevant.
Made fillerChance in Meteor.java a float to allow greater control over configuration. Previously written config files are backwards compatible with this change.
Moved some hard-coded default values to the BM config file.
Created default meteor configs that will be generated if config/BloodMagic/meteors/ is not present.
Improved default config generation by making some code in AlchemicalWizardry.java used to load default schematics a generic function.
Created some README files that will be generated only if config/BloodMagic/meteors/ or config/BloodMagic/meteors/reagents is not present:
README (meteors).txt
README (reagents).txt
Refactored many files and methods related to meteors to remove the word "Paradigm" (like MeteorParadigmComponent -> MeteorComponent) because it just served to make names longer.