-
Notifications
You must be signed in to change notification settings - Fork 43
Add Botania Multiblocks to StructureLib #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Botania Multiblocks to StructureLib #93
Conversation
quick question about gradle: do i need to add StructureLib via compileOnly or api? seems like the check failed because it couldn't find StructureLib. |
does this work outside of GTNH? |
my implementation requires both StructureLib (not sure if this needs to be the GTNH version of it) and BlockRenderer6343. If you have those in your modpack, it should! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I tested this in a mostly empty modpack - It doesn't break in the empty version, but even after adding NEI, structurelib and Blockrenderer I did not get any previews nor any NEI tabs, so that means there are some other undocumented dependencies.
@combusterf did you add GTNHLib aswell (required dependency of StructureLib and BlockRenderer since they use the fastutil data structures)? Seems to be working fine for me with GTNHLib. |
@brandyyn The multiblock projection should be fixed in the latest commit. |
@combusterf I added a StructureLib check so that it's fully optional now. Do you still want me to add documentation on which mods are needed for the StructureLib integration to work? If yes, where would you want me to add them? |
Relatively certain that floating flowers also work for the Mana Enchanter, if there's a way to represent that? (In which case, the dirt isn't necessary.) Also, multiple types of dirt (grass, mycelium, podzol) are allowed, if that's not yet represented. |
@Nikolay-Sitnikov The grass is only for clarity there, so that the flowers don't float in the air. The multiblock itself doesn't require grass to form. I suppose I could make it cycle through each form of grass, but afaik there's no "correct" way to create cycling textures with StructureLib (i did some cheesy stuff to get it working with the flowers) and i don't see much reason as to why it'd be that useful. |
I believe i've fixed the deps now. StructureLib should be 100% optional now and any error should get handled now. If I still need to add more documentation to the deps, lmk. |
src/main/java/vazkii/botania/api/lexicon/multiblock/Multiblock.java
Outdated
Show resolved
Hide resolved
I tried again and it works now in isolation. I've also reviewed the code thoroughly this time and there's one cheeky bug left waiting to happen, so once you've tackled that we're good to go. |
Could the controllers of the multies be added to the NEI tab instead of the multiblock builder? xd |
…y/Botania into multiblock-integration
@EnderProyects wdym by that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to be merged after the feature freeze has ended
Ups nothing, I though that I saw another thing, is okay then |
But, since that, gaia fight "multiblock" could also be added, no? |
@Dream-Master i tested it on beta3 again, pressed every button on the previews and everything worked correctly. I think this change is good for next stable. Would be cool to have this in 2.8 together with the multiblock previews of BH, but that decision is up to you. |
Adds StructureLib multiblock previews from botania (previously, only BH multiblocks were added to StructureLib)