Skip to content

Conversation

sisyphussy
Copy link

@sisyphussy sisyphussy commented Jul 24, 2025

Adds StructureLib multiblock previews from botania (previously, only BH multiblocks were added to StructureLib)

2025-07-24_06 38 40 2025-07-24_06 38 57 2025-07-24_06 39 24

@sisyphussy
Copy link
Author

quick question about gradle: do i need to add StructureLib via compileOnly or api? seems like the check failed because it couldn't find StructureLib.

@Dream-Master Dream-Master requested a review from a team July 24, 2025 12:01
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jul 24, 2025
@brandyyn
Copy link

does this work outside of GTNH?

@sisyphussy
Copy link
Author

my implementation requires both StructureLib (not sure if this needs to be the GTNH version of it) and BlockRenderer6343. If you have those in your modpack, it should!

@brandyyn
Copy link

image

the projection is wrong but it does work in my pack
image

Copy link
Collaborator

@combusterf combusterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I tested this in a mostly empty modpack - It doesn't break in the empty version, but even after adding NEI, structurelib and Blockrenderer I did not get any previews nor any NEI tabs, so that means there are some other undocumented dependencies.

@sisyphussy
Copy link
Author

@combusterf did you add GTNHLib aswell (required dependency of StructureLib and BlockRenderer since they use the fastutil data structures)? Seems to be working fine for me with GTNHLib.

@sisyphussy
Copy link
Author

@brandyyn The multiblock projection should be fixed in the latest commit.

@sisyphussy sisyphussy requested a review from combusterf July 30, 2025 22:26
@sisyphussy
Copy link
Author

@combusterf I added a StructureLib check so that it's fully optional now. Do you still want me to add documentation on which mods are needed for the StructureLib integration to work? If yes, where would you want me to add them?

@Nikolay-Sitnikov
Copy link

Nikolay-Sitnikov commented Jul 31, 2025

Relatively certain that floating flowers also work for the Mana Enchanter, if there's a way to represent that? (In which case, the dirt isn't necessary.)

Also, multiple types of dirt (grass, mycelium, podzol) are allowed, if that's not yet represented.

@sisyphussy
Copy link
Author

@Nikolay-Sitnikov The grass is only for clarity there, so that the flowers don't float in the air. The multiblock itself doesn't require grass to form.

I suppose I could make it cycle through each form of grass, but afaik there's no "correct" way to create cycling textures with StructureLib (i did some cheesy stuff to get it working with the flowers) and i don't see much reason as to why it'd be that useful.

@sisyphussy
Copy link
Author

I believe i've fixed the deps now. StructureLib should be 100% optional now and any error should get handled now. If I still need to add more documentation to the deps, lmk.

@sisyphussy sisyphussy requested a review from a team August 17, 2025 18:08
@combusterf
Copy link
Collaborator

I tried again and it works now in isolation. I've also reviewed the code thoroughly this time and there's one cheeky bug left waiting to happen, so once you've tackled that we're good to go.

@EnderProyects
Copy link

Could the controllers of the multies be added to the NEI tab instead of the multiblock builder? xd

@sisyphussy
Copy link
Author

@EnderProyects wdym by that?

@combusterf combusterf self-requested a review August 26, 2025 19:19
Copy link
Collaborator

@combusterf combusterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to be merged after the feature freeze has ended

@combusterf combusterf added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Aug 26, 2025
@EnderProyects
Copy link

@EnderProyects wdym by that?

Ups nothing, I though that I saw another thing, is okay then

@EnderProyects
Copy link

But, since that, gaia fight "multiblock" could also be added, no?

@sisyphussy
Copy link
Author

@Dream-Master i tested it on beta3 again, pressed every button on the previews and everything worked correctly. I think this change is good for next stable. Would be cool to have this in 2.8 together with the multiblock previews of BH, but that decision is up to you.

@Dream-Master Dream-Master merged commit 825758d into GTNewHorizons:master Sep 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants