Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MuTE Refactor Electric Boogaloo #2530

Closed
wants to merge 10 commits into from
Closed

Conversation

BlueWeabo
Copy link
Member

@BlueWeabo BlueWeabo commented Mar 8, 2024

This will likely not be the last time this will happen as cleaning up is quite hard and questionable decisions were made at the start. But here is a summery of what was done in this refactor:

  • Combine the two blocks that MuTEs had into one
  • Use lang files for translation instead of the gt way. (Could bring it back, but currently don't see a reason for that. Don't think it will be that bad to use a registry's name + meta id for the item to translate it)
  • Make the block store the registry itself and automatically place the TE instead of doing it in a convoluted way of placing the TE.
  • Try and clean up some of the interfaces that existed and simplify quite a lot of the process.
  • Lose Cover functionality for now as I do not want to make another refactor of just renaming an interface over all cover files and making it a skinned down version.
  • Lose waila functionality. not needed right now will add back when it makes more sense.

TODO:

  • Item and Fluids need to be looked at again (maybe 3rd time will be the charm, also needs MUI2..)
  • Trim down Controller class
  • Trim down MultiBlockPart class
  • Trim down MultiTileEntityRegistry class
  • Make a better builder pattern for making MuTEs
  • Find out why GT_Renderer_MultiTileEntities is called every single tick for every single part no matter if its in vision or not or in inventory.

@mitchej123 mitchej123 closed this Jul 9, 2024
@Dream-Master Dream-Master deleted the muteInterfaceRefactor branch July 10, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants