-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add covers that can hold some items #2593
Conversation
Warning: 2 uncommitted changes |
Warning: 2 uncommitted changes |
@Glease feel free to set it undraft when its done. |
da3805a
to
0630009
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And when break the machine block, the items in cover will drop in world, but re-place the machine(with these covers), there still are items in cover's inventory. |
Only somewhat related: I always wished the crafting table cover held an inventory as that would've made it somewhat useful. As it is it behaves like a vanilla crafting table in that all items you place in it are expelled when you close the UI. If you think it would make sense to upgrade the crafting table cover to hold an inventory then you might balance this new "chest cover" alongside it. |
Warning: 2 uncommitted changes |
8d5d328
to
4a23b27
Compare
…/GT5-Unofficial into feature/chestcover
Co-Authored-By: GitHub GTNH Actions <>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well. Good stuff for hand-crafting masters.
This cover allows player to store a small amount of item alongside a machine. The intended use case is for steam to EV player to store extruder shapes and alloy smelter shapes inside the machine. The cover GUI system would then allow player to retrieve the items right from the machine GUI. To facilitate this goal and not make this cover some generic diamond chest, the current line up impose a 1 item per stack limit.
While this demo showcased a 3-slot gui, the submitted PR contains a 3x3 cover instead. The code is structured in a way that the slot count can be tweaked freely without writing any significant code. Multiple cover with different slot count can also be added to game at the same time.
Depends on this bugfix PR in modular UI to work correctly, but does not require that one to be compiled.
New items added
Basic Item Holder: 9 slots. Each slot can only hold ONE item no matter what it is
Good Item Holder. 12 slots. Each slot can only hold ONE item no matter what it is
Advanced Item Holder. 15 slots. . Each slot can only hold ONE item no matter what it is
Screenshots
Task list