Make the EOH store astral arrays internally #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like a EIG-style of UI if possible... |
Yeah a GUI would be better but I unfortunately wasn't able to get it to work. If you or anyone else wants to implement it then feel free to close this PR in favor of the GUI. |
NotAPenguin0
requested changes
Jul 13, 2024
NotAPenguin0
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the EOH store astral arrays internally to prevent them from being moved around between EOHs.
They can be extracted by right clicking the controller with a wire cutter, and are saved to item NBT so they dont get voided if you (accidentally) break the controller.
Existing setups should not be affected, as astral arrays have to be in the input bus anyways, so they will just be removed from the bus and added to the internal counter after updating.