Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DroneHatch to fusion reactor #2670

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

RealSilverMoon
Copy link
Contributor

This aim to merge fusion computers into drone control so people can enable dozens of fusion reactors with one button.
Also reduce the count requirement of input hatches (2->1), since now we have quadruple input hatch & me input hatch.

@Dream-Master Dream-Master requested a review from a team June 19, 2024 08:16
Copy link
Contributor

@NotAPenguin0 NotAPenguin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure about removing the 2 input hatch requirement on fusion reactors. Maybe I'm just being pedantic, but thematically I quite liked there being two input hatches.

I have nothing against adding the drone hatch of course.

@RealSilverMoon
Copy link
Contributor Author

RealSilverMoon commented Jul 15, 2024

This is indeed a ‘traditional structure’ passed down from GT5.08. I’m just tired of having to place a extra but meaningless hatch when using ME Input Hatch or Quadruple Input Hatch on the reactor. (And adding an unnecessary TileEntity as well)

@Dream-Master Dream-Master requested a review from a team July 15, 2024 06:26
Copy link
Contributor

@NotAPenguin0 NotAPenguin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the quad hatches already worked for fusions then I have no objections to lowering the hatch limit

@Dream-Master Dream-Master merged commit de36e0a into GTNewHorizons:master Jul 15, 2024
2 checks passed
@RealSilverMoon RealSilverMoon deleted the newFusion branch August 2, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants