Added Water Pump

[evgengoldwar]

Water Pump :

Tier 1 :

Tier 2 :

[chochem]

did you discuss this with the dev team at all? please dont make big changes like this to early without any prior discussion.

here some obvious starting question:
why?
how much does it make? (tooltip is very unclear)
how much fuel/what type of fuel does it take?

[evgengoldwar]

did you discuss this with the dev team at all? please dont make big changes like this to early without any prior discussion.

here some obvious starting question: why? how much does it make? (tooltip is very unclear) how much fuel/what type of fuel does it take?

Dream asked to add to the existing Steam Washer as it requires a lot of water.
The water extraction formula is written in the tooltip. Humidity and Tiers are written in the wailla on the controller.
It requires nothing to run.

[chochem]

This is not a steam washer.
As I said the tooltip is totally unclear. (no time frame! 40% humidity is 40 or 0.4?)
A pump that runs on nothing is nonsense. We already have a water pump and it uses fuel.

[chochem]

to add to those questions: why would humidity affect a water pump?

[Reflex18]

Is this a replacement to the Stirling dynamo and an upgrade to the railcraft water tanks?

[evgengoldwar]

This is not a steam washer. As I said the tooltip is totally unclear. (no time frame! 40% humidity is 40 or 0.4?) A pump that runs on nothing is nonsense. We already have a water pump and it uses fuel.

40% = 40 As already said in wailla the humidity of the biome is deduced

[Dream-Master]

The new washer need tons of water so a pump is a nice idea and needed. About blance when can discuss.

[evgengoldwar]

to add to those questions: why would humidity affect a water pump?

It's a mix of Railcraft Water tank and Pump from Impact.

[chochem]

Is this a replacement to the Stirling dynamo and an upgrade to the railcraft water tanks?

replacing the stirling pump with something nicer looking (at roughly the same mechanics) could be a cool thing yea. that is not what this is sadly.

[chochem]

This is not a steam washer. As I said the tooltip is totally unclear. (no time frame! 40% humidity is 40 or 0.4?) A pump that runs on nothing is nonsense. We already have a water pump and it uses fuel.

40% = 40 As already said in wailla the humidity of the biome is deduced

you are not saying anything if you dont say the time frame. for th railcraft tanks its 8 ticks. but for all I know you mean per second or per tick instead.

[chochem]

The new washer need tons of water so a pump is a nice idea and needed. About blance when can discuss.

we have a pump already dream

[evgengoldwar]

This is not a steam washer. As I said the tooltip is totally unclear. (no time frame! 40% humidity is 40 or 0.4?) A pump that runs on nothing is nonsense. We already have a water pump and it uses fuel.

40% = 40 As already said in wailla the humidity of the biome is deduced

you are not saying anything if you dont say the time frame. for th railcraft tanks its 8 ticks. but for all I know you mean per second or per tick instead.

per second

[chochem]

thanks for answering some questions. Though these discussion should really happen in advance and not on the PR.

I propose we close this PR.

We already have a water pump which is better (excepty for looks). Specifically:

• a water pump based on humidity makes no sense.
• a water pump without power/fuel of any kind makes no sense.
• adding some bronze to a water tank to make it produce (literally) 200x as much makes no sense.

If the reason for this was the new steam washer, there is a much simpler solution. Reduce the water consumption. It acts as a simple washer only, right? Meaning no byprodructs. You can simple wash 3 stacks of material with 1000L water in a cauldron, so low water usage for simple washing has precedent in the game.

Regarding water pumps, I could see us using a multiblock structure like this as a replacement for the existing (stirling) water pump but with its existing mechanics (based on fuel not humidity), just to make it look nicer. Outside of looks the existing water pump seems fine.

[Dream-Master]

The steam washer has byproducts. Its not a simple washer.
The stirling Water pump from bartworks was a duct tape solution and never a very good way to generate water.
reduce the amount of water make the single block washer completly useless and break balance.
About how this pump have to generate/pump water we can discuss.

[dahgul333]

thanks for answering some questions. Though these discussion should really happen in advance and not on the PR.

I propose we close this PR.

We already have a water pump which is better (excepty for looks). Specifically:

* a water pump based on humidity makes no sense.

* a water pump without power/fuel of any kind makes no sense.

* adding some bronze to a water tank to make it produce (literally) 200x as much makes no sense.

If the reason for this was the new steam washer, there is a much simpler solution. Reduce the water consumption. It acts as a simple washer only, right? Meaning no byprodructs. You can simple wash 3 stacks of material with 1000L water in a cauldron, so low water usage for simple washing has precedent in the game.

Regarding water pumps, I could see us using a multiblock structure like this as a replacement for the existing (stirling) water pump but with its existing mechanics (based on fuel not humidity), just to make it look nicer. Outside of looks the existing water pump seems fine.

1. We alredy have humidiry based water source - Water Tank (If you want a near-realistic justification, the groundwater depends on humidity+-.
   2)instead of fuel, we pay with the cost of the structure
   3)I don't see any point in being greedy for water.

[Dream-Master]

This pump use steam which need coal to work. About the pump rate and other balacing stuff we can discuss here or in Discord.

[chochem]

The steam washer has byproducts. Its not a simple washer. The stirling Water pump from bartworks was a duct tape solution and never a very good way to generate water. reduce the amount of water make the single block washer completly useless and break balance. About how this pump have to generate/pump water we can discuss.

why does it have byproducts? the steam macerator does not.

[chochem]

This pump use steam which need coal to work. About the pump rate and other balacing stuff we can discuss here or in Discord.

no. they say it uses nothing.

[ah-OOG-ah]

The steam washer has byproducts. Its not a simple washer. The stirling Water pump from bartworks was a duct tape solution and never a very good way to generate water. reduce the amount of water make the single block washer completly useless and break balance. About how this pump have to generate/pump water we can discuss.

why does it have byproducts? the steam macerator does not.

Probably because unlike the macerator, there is an LV washer that gives byproducts. It's just slower and more expensive to run.

[Dream-Master]

Pump need to used Steam so it need to be changed. About Byproducts. Lv macerator has no byproducts same as multi. Lv washer has byproducts same as the new multi

outdated

[chochem]

Steam based is a good approach. Apparently that was Dreams idea from the start, so that is great.
And at least not depending on skycheck but only humidity improves things a lot on that front for sure.

Outside of improving the tooltip, I guess a big discussion point left is balance. If I understand correctly this now produces 5000L/s water for 400L/s running cost. Well with the production scaled down proportionally at less than 100 humidity and doubled with steel tier though the steam consumption remains the same. (please correct me if wrong)
For comparison the passive railcraft water tank makes 25L/s water at 100 humidity and the coal/charcoal/similar based existing water pump makes 150L/s (I dont remember the fuel consumption rate).
So right now even just the bronze tier is like 200 water tanks (but with steam consumption!) or like 33 water pumps (and probably more efficient. That is a lot, and way more than you need in steam age, even with the washer. (and its highly unlikely you will run the washer a lot with max parallels anyway)

[NotAPenguin0]

There are a few minor code quality nitpicks I'd like to see addressed. Some of these aren't necessary, but would improve maintainability a little and make it easier for others unfamiliar with the implementation to change this in the future.

There's also a few other things like trying to automatically determine the tier of the multi instead of having to set it with a screwdriver, but overall well done on the multi.

As for balancing, I think in it's current state it's mostly fine. Spamming the RC water siding tanks in Steam/Early LV is not very interesting in my opinion, so having a pump multiblock that's a bit stronger does make some sense. It would also increase the viability of the large boilers in LV/MV a bit, which I'm all for.

[NotAPenguin0]

No more comments from me

[Dream-Master]

if the values need to be changed we can do another pr