Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some stuff I removed long ago #2702

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

Cardinalstars
Copy link
Contributor

This PR addresses this issue:
GTNewHorizons/GT-New-Horizons-Modpack#15192 (comment)

Tested with the pack aswell

return machineEntity instanceof CoverableTileEntity cte && cte.getCoverInfoAtSide(forgeSide)
.getCoverID() != 0;
return machineEntity instanceof BaseMetaTileEntity bmte && (bmte.getCoverInfoAtSide(forgeSide)
.getCoverID() != 0 || bmte.getMetaTileEntity() instanceof GT_MetaTileEntity_RedstoneBase);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a good look at this part. I'm not sure how else I should do it honestly.

@Cardinalstars Cardinalstars marked this pull request as ready for review July 1, 2024 14:38
@Dream-Master Dream-Master requested review from a team and AbdielKavash July 1, 2024 18:40
Copy link
Contributor

@NotAPenguin0 NotAPenguin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@Dream-Master Dream-Master merged commit 1ab7b9d into GTNewHorizons:master Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants