Fix crash when ctrl-pressing the "+" in NEI to autocraft missing components #50
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have you checked if any other mod calls that constructor? |
|
only AE2FC itself, but i couldnt find any crash with that |
sisyphussy
approved these changes
Sep 1, 2025
sisyphussy
added
the
safe for stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title says. Tested in SP and it works as intended again.
should fix GTNewHorizons/GT-New-Horizons-Modpack#21028
issue is, that AE2FC had its CPacketInventoryAction method args changed from
(action, int, int) to (action, int, long) which gave the NoSuchMethodError
not 100% sure that this is fully correct, but from my testing it fixes the issue