Inspector : Direct edits should set the TweakPlug to Create mode

GafferHQ · Feb 14, 2025 · cf766b8 · cf766b8
1 parent e195bae
commit cf766b8
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/python/GafferSceneUITest/AttributeInspectorTest.py b/python/GafferSceneUITest/AttributeInspectorTest.py
@@ -1082,5 +1082,11 @@ def assertEdit( inspection, data, nonEditableReason ) :
 		self.assertEqual( acquiredEdit["enabled"].getValue(), True )
 		self.assertEqual( acquiredEdit["value"].getValue(), 789.0 )
 
+		# Editing an existing edit should set its mode to `Create`
+		acquiredEdit["mode"].setValue( Gaffer.TweakPlug.Mode.Multiply )
+		assertEdit( inspection, IECore.FloatData( 123.0 ), "" )
+		self.assertEqual( acquiredEdit["mode"].getValue(), Gaffer.TweakPlug.Mode.Create )
+		self.assertEqual( acquiredEdit["value"].getValue(), 123.0 )
+
 if __name__ == "__main__" :
 	unittest.main()
diff --git a/python/GafferSceneUITest/OptionInspectorTest.py b/python/GafferSceneUITest/OptionInspectorTest.py
@@ -1094,5 +1094,11 @@ def assertEdit( inspection, data, nonEditableReason ) :
 		self.assertTrue( acquiredEdit["enabled"].getValue() )
 		self.assertEqual( acquiredEdit["value"].getValue(), "/anotherCamera" )
 
+		# Editing an existing edit should set its mode to `Create`
+		acquiredEdit["mode"].setValue( Gaffer.TweakPlug.Mode.ListAppend )
+		assertEdit( inspection, IECore.StringData( "/existingCamera" ), "" )
+		self.assertEqual( acquiredEdit["mode"].getValue(), Gaffer.TweakPlug.Mode.Create )
+		self.assertEqual( acquiredEdit["value"].getValue(), "/existingCamera" )
+
 if __name__ == "__main__" :
 	unittest.main()
diff --git a/python/GafferSceneUITest/ParameterInspectorTest.py b/python/GafferSceneUITest/ParameterInspectorTest.py
@@ -1269,5 +1269,11 @@ def assertEdit( inspection, data, nonEditableReason ) :
 		self.assertTrue( acquiredEdit["enabled"].getValue() )
 		self.assertEqual( acquiredEdit["value"].getValue(), 789.0 )
 
+		# Editing an existing edit should set its mode to `Create`
+		acquiredEdit["mode"].setValue( Gaffer.TweakPlug.Mode.Max )
+		assertEdit( inspection, IECore.FloatData( 123.0 ), "" )
+		self.assertEqual( acquiredEdit["mode"].getValue(), Gaffer.TweakPlug.Mode.Create )
+		self.assertEqual( acquiredEdit["value"].getValue(), 123.0 )
+
 if __name__ == "__main__":
 	unittest.main()
diff --git a/src/GafferSceneUI/Inspector.cpp b/src/GafferSceneUI/Inspector.cpp
@@ -215,6 +215,7 @@ void edit( Gaffer::ValuePlug *plug, const IECore::Object *value )
 	else if( auto tweakPlug = runTimeCast<TweakPlug>( plug ) )
 	{
 		tweakPlug->enabledPlug()->setValue( true );
+		tweakPlug->modePlug()->setValue( TweakPlug::Mode::Create );
 		valuePlug = tweakPlug->valuePlug();
 	}
 	else if( auto optionalValuePlug = runTimeCast<OptionalValuePlug>( plug ) )