renderPassEditor : Fix errors when script is not parented to Application #6262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
At IE we create a custom ScriptNode that holds Jabuka nodes, and then show node editors to edit/view the asset properties.
In the latest gaffer release, we were seeing errors because the
renderPassEditor.py
gui startup config would run for those scripts when inside the gaffer app, and it expected that the script would be parented to an application.We were seeing similar errors before, but I had been able to deal with those without a change in gaffer (by never trying to create a
ScriptWindow
for theJabukaScriptNode
).But this latest error is trickier for us to fix without a major redesign of
Jabuka
, since there are plug widgets in gaffer that require that the node being edited is parented to a script that as a correspondingScriptWindow
(like the color swatch widget). I guess an option would be to parent theJabukaScriptWindow
to thegaffer
application, but that likely would cause other sorts of issues (now or in the future).So I'm suggesting this simple safeguard in gaffer for now.
Checklist