Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderPassEditor : Fix errors when script is not parented to Application #6262

Merged

Conversation

ivanimanishi
Copy link
Member

Related issues

At IE we create a custom ScriptNode that holds Jabuka nodes, and then show node editors to edit/view the asset properties.
In the latest gaffer release, we were seeing errors because the renderPassEditor.py gui startup config would run for those scripts when inside the gaffer app, and it expected that the script would be parented to an application.

We were seeing similar errors before, but I had been able to deal with those without a change in gaffer (by never trying to create a ScriptWindow for the JabukaScriptNode).

But this latest error is trickier for us to fix without a major redesign of Jabuka, since there are plug widgets in gaffer that require that the node being edited is parented to a script that as a corresponding ScriptWindow (like the color swatch widget). I guess an option would be to parent the JabukaScriptWindow to the gaffer application, but that likely would cause other sorts of issues (now or in the future).

So I'm suggesting this simple safeguard in gaffer for now.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

This can happen at IE where we create custom script nodes that are not
attached to the gaffer application.
@johnhaddon johnhaddon merged commit 45b9f41 into GafferHQ:1.5_maintenance Feb 7, 2025
4 of 5 checks passed
@ivanimanishi ivanimanishi deleted the renderPassEditorStartupFix branch February 7, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants