Skip to content

Implementing append features & backups#18

Draft
JojoBoulais wants to merge 1 commit intomainfrom
append_ingest_mode
Draft

Implementing append features & backups#18
JojoBoulais wants to merge 1 commit intomainfrom
append_ingest_mode

Conversation

@JojoBoulais
Copy link
Copy Markdown
Collaborator

No description provided.

@sgagliano sgagliano requested a review from xiaoh11 April 7, 2026 22:28
((k, json.dumps(v)) for k, v in data.items()),
)

if os.path.exists(out_filepath):
Copy link
Copy Markdown
Collaborator Author

@JojoBoulais JojoBoulais Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if statement not necessary

@xiaoh11 xiaoh11 requested a review from dtaliun April 8, 2026 18:35
@xiaoh11 xiaoh11 closed this Apr 8, 2026
@xiaoh11 xiaoh11 reopened this Apr 8, 2026
""")

if __name__ == "__main__":
ffibuilder.compile(verbose=True) No newline at end of file
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was used to compile cpp. could be removed

return 0;
}

int append_to_matrix(const char *sites_filepath,
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works if old phenotypes are not being updated. Only new phenotypes are being ingested.

Comment thread pheweb_api/load/sites.py
# if os.path.exists(out_filepath) and not force:
# if mtime(out_filepath) >= max(mtime(f["filepath"]) for f in manna.files):
# print("The list of sites is up-to-date!")
# return
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove commented previous code block

Comment thread pheweb_api/load/sites.py
print("The list of sites is up-to-date!")
return

print("test")
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants