Issue 133/auditor staking#193
Merged
gabito1451 merged 4 commits intoGalactiGuild:mainfrom Mar 29, 2026
Merged
Conversation
|
@binayyub4211 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@binayyub4211 PLEASE look in to the ci fail |
Contributor
|
please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #133
What was done: Implemented an economic security layer for the Milestone Oracle network:
Staking Management: Added
set_staking_config
,
deposit_stake
,
request_unstake
, and
withdraw_stake
functions.
Lockup Period: Enforced a configurable lockup period for unstaking requests to prevent malicious exit immediately after voting.
Voting Safeguard: Integrated a check in the
vote
function to ensure auditors meet the minimum staking requirement.
Persistence: Used persistent storage for tracking auditor stakes and pending unstake requests.
Why it was done: To provide economic security for the decentralized oracle system, ensuring auditors have a financial stake that prevents sybil attacks and dishonest behavior during milestone verification.
How it was verified:
Added unit tests in
milestone-oracle/src/lib.rs
covering stake deposits, vote validation (minimum stake check), and lockup enforcement (using ledger timestamp manipulation).
Manual code review for access control and transaction safety.