Feature/smart wallet recovery#196
Merged
gabito1451 merged 6 commits intoGalactiGuild:mainfrom Mar 27, 2026
Merged
Conversation
|
@Xhristin3 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Create LimitOrders contract with order book functionality - Implement buy/sell limit orders with price-time priority - Add market order execution against existing limit orders - Support partial fills and order cancellation - Gas-optimized storage and matching logic - Comprehensive documentation in LIMIT_ORDERS_DOCUMENTATION.md Features: - Order types: Buy (bid) and Sell (ask) - Order status: Active, PartiallyFilled, Filled, Cancelled - Price encoding: Scaled integers (1e6 precision) - Automatic matching when AMM price crosses limit - Market orders for instant execution
- Create SmartWallet contract with account abstraction - Implement N-of-M guardian social recovery (minimum 3 guardians) - Add configurable threshold for recovery approval - 48-hour time-lock on recovery execution for security - Owner can add/remove guardians and cancel recovery requests - Support for executing transactions on behalf of wallet - Comprehensive test coverage including minimum 3 guardians requirement Security features: - Separation of owner and guardian roles - Threshold-based recovery prevents single point of failure - Time-lock allows owner to intervene if recovery is malicious - Replay protection via nonce increment
- Create SMART_WALLET_DOCUMENTATION.md with full usage guide - Document security features and attack mitigation strategies - Include recovery flow diagrams and integration examples - Add gas optimization tips and best practices - Provide deployment instructions and test coverage summary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Implement a generic Soroban smart wallet contract supporting social recovery (N-of-M guardians to reset the master key).
Requirements and context:
Key management is too hard for mass-market users.
Suggested execution:
Build smart_wallet.rs following Account Abstraction concepts on Stellar.
Guidelines:
Minimum 3 guardians required in tests.
closes #129