Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Triaxial or Flattened potential wrapper or operator for any spherical potential model #194

Open
adrn opened this issue Mar 6, 2024 · 0 comments · May be fixed by #271
Open

Enable Triaxial or Flattened potential wrapper or operator for any spherical potential model #194

adrn opened this issue Mar 6, 2024 · 0 comments · May be fixed by #271
Milestone

Comments

@adrn
Copy link
Collaborator

adrn commented Mar 6, 2024

As we discussed on the call, this would enable making any spherical potential a triaxial model (in the potential). API to be worked out, but the idea would be to not have to implement flattened and triaxial versions of all potential models. Instead, we want something like (names of arguments and wrappers TBD):

pot = Triaxial(HernquistPotential(...), axis_ratio1=..., axis_ratio2=...)
pot2 = Flattened(HernquistPotential(...), axis_ratio=...)
@adrn adrn added this to the v0.1 milestone Mar 6, 2024
@nstarman nstarman linked a pull request Apr 27, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant