Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: triaxiality (potential) wrapper #271

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nstarman
Copy link
Contributor

Closes: #194

TODO:

  • Tests
  • Docstrings
  • Remove / deprecate / do something to TriaxialHernquist
  • Make public (__all__, pyi, etc)

@nstarman nstarman added this to the v0.2 milestone Apr 27, 2024
@nstarman nstarman requested a review from adrn April 27, 2024 23:21
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 94.10%. Comparing base (d72457c) to head (9c2fe89).

Files Patch % Lines
src/galax/potential/_potential/triaxial.py 79.31% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   94.24%   94.10%   -0.15%     
==========================================
  Files          59       60       +1     
  Lines        2310     2339      +29     
==========================================
+ Hits         2177     2201      +24     
- Misses        133      138       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman force-pushed the pot-triaxial-potential branch 4 times, most recently from 6a54c3e to b79e5d7 Compare April 30, 2024 21:01
@nstarman nstarman mentioned this pull request May 30, 2024
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Triaxial or Flattened potential wrapper or operator for any spherical potential model
1 participant