feat: orbit metadata #259
Open
feat: orbit metadata #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 93.32% 93.44% +0.11%
==========================================
Files 55 55
Lines 1993 2014 +21
==========================================
+ Hits 1860 1882 +22
+ Misses 133 132 -1 ☔ View full report in Codecov by Sentry. |
nstarman
force-pushed
the
orbit-metadata
branch
3 times, most recently
from
704d5f2
to
5c1548b
Compare
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
nstarman
force-pushed
the
orbit-metadata
branch
from
5c1548b
to
7483ad2
Compare
|
I've been seeing some issues with tracer leakage in this PR! Need to figure out how to prevent that, otherwise this is a no-go for the current selection of MetaData. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some read-only metadata to
OrbitandMockStream.I'm not 100% sure what metadata we want, just that something seems useful.