Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Galax to Gala io #375

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Jul 4, 2024

  • First use case for as_interop (Galax Feature Parity #298)
  • Major cleanup of I/O.
  • consolidate a lot of private API.
  • Better docs: 1. plum.dispatch combines the docs for IDEs, 2. we can show round-tripping of the potential.
  • Access to galpy via galax -> gala -> galpy!

@nstarman nstarman added this to the v0.1 milestone Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 86.17886% with 34 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (ffb7f56) to head (8f3b7c8).

Files Patch % Lines
src/galax/_galax_interop_gala/potential.py 86.12% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   94.81%   94.31%   -0.50%     
==========================================
  Files          69       69              
  Lines        2449     2621     +172     
==========================================
+ Hits         2322     2472     +150     
- Misses        127      149      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman
Copy link
Contributor Author

nstarman commented Jul 5, 2024

Gonna add more docstrings (which are also tests). Then all the available conversions should be fully documented.
A good followup PR would be to allow a time argument when converting from galaxy to gala /galpy
Edit: done! Every conversion function has an example. These are all doctested.

@nstarman nstarman marked this pull request as ready for review July 5, 2024 18:03
@nstarman nstarman marked this pull request as draft July 5, 2024 18:03
@nstarman
Copy link
Contributor Author

nstarman commented Jul 5, 2024

Potentials requiring GSL remain untested (#278)

@nstarman nstarman marked this pull request as ready for review July 5, 2024 19:54
@nstarman
Copy link
Contributor Author

nstarman commented Jul 8, 2024

Ping @adrn, does this look good to you?

@nstarman
Copy link
Contributor Author

I'm going to branch this PR to get started on the galax <-> galpy I/O.

@nstarman nstarman mentioned this pull request Jul 12, 2024
83 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant