Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use ImmutableMap #382

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Jul 11, 2024

coordinax needs ImmutableMap, so I've spun it out into a separate repo and in this PR we change to using that repo.
It would be great to use a quality 3rd party solution but there are issues GalacticDynamics/xmmutablemap#2

Signed-off-by: nstarman <[email protected]>
@nstarman nstarman added this to the v0.1 milestone Jul 11, 2024
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
@nstarman nstarman marked this pull request as ready for review July 11, 2024 03:44
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.81%. Comparing base (4e29e25) to head (173233e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   94.84%   94.81%   -0.04%     
==========================================
  Files          70       69       -1     
  Lines        2483     2449      -34     
==========================================
- Hits         2355     2322      -33     
+ Misses        128      127       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nstarman <[email protected]>
@nstarman nstarman merged commit ffb7f56 into GalacticDynamics:main Jul 11, 2024
14 of 15 checks passed
@nstarman nstarman deleted the use-immutablemap branch July 11, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant