-
Notifications
You must be signed in to change notification settings - Fork 26
feat: enable Soroswap Smart Wallet support with DeFi safety validation (#165) #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KevinMB0220
merged 4 commits into
Galaxy-KJ:main
from
Jopsan-gm:feature/issue-165-soroswap-smart-wallet
Mar 28, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c55f657
feat(wallet): enable Soroswap Smart Wallet support with DeFi safety v…
Jopsan-gm 35249e1
fix(tests): use valid Stellar address in BlendProtocol liquidation tests
Jopsan-gm 2fbad41
Merge upstream/main: resolve conflicts in favor of feature branch cha…
Jopsan-gm cff1f80
test: improve code coverage and fix test suite
Jopsan-gm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: Galaxy-KJ/Galaxy-DevKit
Length of output: 1054
🏁 Script executed:
Repository: Galaxy-KJ/Galaxy-DevKit
Length of output: 1401
getStatserror-path test is brittle and likely not testing the intended branch.Line 252 monkey-patches
Date.prototype.getTime, butnew Date()does not callgetTime()during construction—it only initializes the Date object. This means the patch never triggers an error, and the catch block is never exercised. The test becomes a false-positive. Additionally, global mutation restoration is not guarded withfinally.Suggested test hardening
it('should handle errors in getStats gracefully', async () => { - // Force an error by corrupting the internal state - const originalNew = Date.prototype.getTime; - Date.prototype.getTime = (() => { throw new Error('Time error'); }) as any; - - const stats = await soroswapProtocol.getStats(); - - // Should still return default stats due to error handling - expect(stats).toBeDefined(); - - // Restore original function - Date.prototype.getTime = originalNew; + const RealDate = Date; + (global as any).Date = class extends RealDate { + constructor(...args: any[]) { + if (args.length === 0) throw new Error('Time error'); + super(...args as []); + } + } as any; + try { + await expect(soroswapProtocol.getStats()).rejects.toThrow(/Time error|getStats/i); + } finally { + (global as any).Date = RealDate; + } });📝 Committable suggestion
🤖 Prompt for AI Agents