Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 implement component mission protection system #37

Merged
merged 6 commits into from
May 21, 2024

Conversation

peterohanley
Copy link
Contributor

@peterohanley peterohanley commented May 15, 2024

Describe your changes

What changes have you implemented?

I have extracted the src folder of the HARDENS repo and other required folders (firmware) and replaced the submodule with it so we can make changes. I have started converting the frama-c specs to cn specs.

Issue ticket number and link

It is a partial fix for #11

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code matches the coding standards and I have ran the appropriate linters
  • I included documentation updates for my code
  • I extended the test suite and the tests run by the CI to cover my code
  • I assigned a Milestone to this PR
  • I assigned this PR to a Project
  • I assigned this PR appropriate Labels

@peterohanley peterohanley added hardware SUT hardware (real/emulated/simulated) application software application software components labels May 15, 2024
@peterohanley peterohanley added this to the MVP 1 milestone May 15, 2024
@peterohanley peterohanley self-assigned this May 15, 2024
@peterohanley
Copy link
Contributor Author

If you limit the diff to only one commit at a time it is much easier to parse the changes.

@@ -26,6 +26,8 @@
// Instrumentation
// Trip modes:
#define NINSTR 4
/*@ function (u8) NINSTR() @*/
uint8_t c_NINSTR() /*@ cn_function NINSTR; @*/ { return NINSTR; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mentioned as the idiomatic way to do this here but in a header file this way produces multiple copies the linker will choke on and in a source file the value won't be available to cn in other source files.

@podhrmic
Copy link
Collaborator

Pre-review:

  • HARDENS submodule can be removed
  • files currently in HARDENS folder should be pumped up by 1 level - so HARDENS/src will become src (I cannot even checkout the branch now)
  • hardware folder can be removed - AFAIK there are no specs there?

@podhrmic
Copy link
Collaborator

  • Coding standards: we don't have linters yet, so I am happy skipping that point for now
  • Docs: can be updated in a separate MR

@peterohanley
Copy link
Contributor Author

  • HARDENS submodule can be removed

I have removed it in the first commit dcf8423

  • files currently in HARDENS folder should be pumped up by 1 level - so HARDENS/src will become src (I cannot even checkout the branch now)

Apparently not in the right way.

  • hardware folder can be removed - AFAIK there are no specs there?

It's in the include path, but it can be stripped down further.

@podhrmic
Copy link
Collaborator

Screenshot from 2024-05-17 10-50-37

@peterohanley peterohanley merged commit 6693ed0 into main May 21, 2024
@peterohanley peterohanley deleted the 11-implement-component-mission-protection-system branch May 21, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application software application software components hardware SUT hardware (real/emulated/simulated)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants