Fix cmake message severity to avoid scaring users#566
Merged
Conversation
Change informational messages about excluded/disabled features from alarming BoldRed to BoldCyan (consistent with existing exclusion messages). Red should be reserved for actual errors. Changes: - warnings.cmake: Remove red color from "Werror is disabled" and add clarifying text "(this is normal for most builds)" - utilities.cmake: Change h5py/hdf5 version mismatch from BoldRed to Yellow note, clarify it only affects specific backends like pbarlike - optional.cmake: Change missing MPI, HDF5, SQLite, ROOT messages from BoldRed to BoldCyan with "X" prefix - externals.cmake: Change c++14/17 requirement message to BoldCyan - preprocessor.cmake: Change graphviz not found message to BoldCyan 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ChrisJChang
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BoldRedtoBoldCyan(consistent with existing exclusion messages)Changes
BoldRedtoYellownote, clarify it only affects specific backends like pbarlikeBoldRedtoBoldCyanwith "X" prefixBoldCyanBoldCyanRationale
The
BoldCyanwith "X" prefix pattern is already used elsewhere in the codebase for disabled features (e.g., "MPI is disabled"), so this makes the messaging consistent. Users should only see red when something actually requires their attention.Test plan
🤖 Generated with Claude Code