Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add create game usecase #98

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

shmily7829
Copy link
Collaborator

@shmily7829 shmily7829 commented Sep 24, 2023

  1. 新增了 Create Game 的 Usecase
  2. 調整 App 層 output 資料夾的名稱為 repositories
  3. Presnter 把 getEvent 方法抽出來放在 AbstractPresenter
  4. 調整 RollDiceUseCase 的方法簽章 diceCount -> isTwoDices
    resolved Create Game Usecase #95

1. add create game usecase
2. application output file rename to repositories
3. create AbstractPresenter
4. refactor method rollDice arg, dices count to isTwoDices
1. add create game usecase
2. application output file rename to repositories
3. create AbstractPresenter
4. refactor method rollDice arg, dices count to isTwoDices
}

public List<DomainEvent> rollDice(String playerId, boolean isTwoDices) {
// TODO : isTwoDices 可以用 true or false 判斷,因為我們只有一顆骰子或兩顆骰子的情況
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這行 TODO 可以移除了

@keytsai keytsai merged commit 976cdb0 into develop Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants