-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Points and Contact Manifold #1301
Contact Points and Contact Manifold #1301
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (2/4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (3/4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (4/4)
51a786a
to
c7fbe41
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
- Coverage 36.25% 35.94% -0.31%
==========================================
Files 395 398 +3
Lines 31537 31876 +339
==========================================
+ Hits 11433 11458 +25
- Misses 20104 20418 +314 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work, ty very much for working on this! Also ran the sample on my PC, very cool to see the results 👀
Performance wise I'm sure we can improve this a lot further but it's not worth it to waste time on that right now. The only thing I think you should change on that part is replacing std::list
by std::vector
- unless you've a reason for sticking to the former ofc.
Also sorry for the review delay once again!
Also it would be cool to link those resources in the code itself so that it doesn't get forgotten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post resolving the pending conversations; lgtm
f59816b
to
d8c8ba3
Compare
f9876c4
to
2f6ccfe
Compare
Description
(yup, that's all)
To support this:
I'll gladly take any suggestions so Box.hpp doesn't look so ugly.
Resources:
https://research.ncl.ac.uk/game/mastersdegree/gametechnologies/previousinformation/physics5collisionmanifolds/2017%20Tutorial%205%20-%20Collision%20Manifolds.pdf
https://research.ncl.ac.uk/game/mastersdegree/gametechnologies/physicstutorials/4collisiondetection/Physics%20-%20Collision%20Detection.pdf
Also used the structures to hold the date in Box2D/Avian for reference.
Checklist