Make Cubos compatible with CMake find_package #1327
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiscadoA
added
C-Code-Quality
|
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1327 +/- ##
=======================================
Coverage 36.18% 36.18%
=======================================
Files 402 402
Lines 32096 32096
=======================================
Hits 11614 11614
Misses 20482 20482 ☔ View full report in Codecov by Sentry. |
RiscadoA
changed the title
RiscadoA
changed the title
RiscadoA
force-pushed
the
1326-make-cubos-usable-in-cmake-through-find_package
branch
from
528aa87
to
1a572b1
Compare
RiscadoA
force-pushed
the
1326-make-cubos-usable-in-cmake-through-find_package
branch
from
1a572b1
to
0e47178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is still very barebones. I tried to quickly give this a shot for 0.4 but it's way more complex than I anticipated.
I think we need to refactor pretty much the whole CMake configuration, as dealing with two libs at once (engine and core), plus their dependencies, of which some are obtained from add_subdirectory instead of find_package, is a big pain.
Checklist