Skip to content

Conversation

@KristopherKubicki
Copy link
Member

Summary

  • allow HAR/DAR examples by updating .gitignore
  • provide minimal examples.har and example.dar in new samples/ folder
  • update README with quick commands for inspecting sample files

Testing

  • PYTHONPATH=. python tests/test_converter.py
  • PYTHONPATH=. python tests/test_dar_parser.py

https://chatgpt.com/codex/tasks/task_e_6840809bdfe483338234d24c28361f79

Copilot AI review requested due to automatic review settings June 4, 2025 17:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds sample HAR and DAR files to the samples/ folder, updates .gitignore to include these examples, and enhances the README with commands to inspect them.

  • Introduce samples/example.har as a minimal HAR example.
  • Introduce samples/example.dar as a minimal DAR example.
  • Update README to show how to view sample files with less and jq.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
samples/example.har Add a minimal HAR example with empty entries.
samples/example.dar Add a minimal DAR example including a render.
README.md Add instructions for inspecting samples via CLI.
Comments suppressed due to low confidence (1)

README.md:50

  • [nitpick] This paragraph is no longer formatted as a list item under the Examples section. Consider prefixing it with a dash or indenting it consistently to match the surrounding markdown list style.
Check the `samples/` directory for example `.har` and `.dar` files. These samples let you try the converter and inspect DAR output immediately. To view them from the command line:

"renders": [
{
"url": "https://example.com",
"status": "200",
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTTP status code is represented as a string here, but the DAR schema (and HAR conventions) expect a numeric value. Change it to a number (e.g., 200) for consistency.

Suggested change
"status": "200",
"status": 200,

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants