Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Helper Functions #23

Merged
merged 3 commits into from
Sep 2, 2023
Merged

Improve Helper Functions #23

merged 3 commits into from
Sep 2, 2023

Conversation

semio
Copy link
Collaborator

@semio semio commented Aug 29, 2023

  • Fixed an issue in Spark API
  • Support loading all prompts and questions, instead of only loading those marked as included in next evaluation.
  • Support filter questions by language.
  • Update exploration notebook to show the usage of helper functions.

@semio
spark api url should be created on the fly
fe644fa 
because there is time info in the url. one url will become outdated after some minutes.
@semio
update helpers
7634ed1 
- support loading all prompts and questions, instead of only loading
  those marked as included in next evaluation.
- support filter questions by language.
@semio
update notebook
99c6a92
@semio
Copy link
Collaborator Author

semio commented Aug 29, 2023 •
edited
Loading

@motin After adding language field to questions, the question_id and question_option_id field are not unique for now, do you think it will be a problem?

for now we need to take care of language when filtering the list

gapminder-ai/automation-api/lib/pilot/helpers.py

Line 105 in 99c6a92

(options["question_id"] == qid) & (options["language"] == lang)

@semio semio merged commit 504e332 into main Sep 2, 2023
2 checks passed
@semio semio deleted the helper_update branch September 2, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motin motin motin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semio @motin