-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake docs. #2
base: master
Are you sure you want to change the base?
CMake docs. #2
Conversation
Erk, I forgot. I'd like to fix the use of |
Fixed I need to update some images from CMake docs. |
Fixed images. I think we can merge. |
Everything looks good except I think the wording in the docs need a few corrections.
This is not very clear. Should probably say something like "ProjectName will be used in these instructions. Replace each instance with your desired ProjectName. Example .. "
"Where to build de binaries" should be "Where to build the binaries" and "Full path to Torque3D to build CMake cache and MSVC solution files." should probably be more clear like "Full path to output project build files (such as MSVC solution)."
This should be "You will see an error message. This is normal, we have to set the name of the project."
Should be "The new configuration variables are marked in red."
Where to build the binaries.
I don't fully understand this so I can't rewrite it. Can you clarify what this step means? |
@andr3wmac Thanks for that. I figured I'd go through and do that later after this was accepted, since the loop is tighter that way (i.e. no need to critique -> Luis make changes -> update PR). WRT that last part, the |
Docs for build project with CMake.