Skip to content

Implement Figure.pygmtlogo for the PyGMT logo#4616

Open
seisman wants to merge 26 commits into
mainfrom
pygmtlogo
Open

Implement Figure.pygmtlogo for the PyGMT logo#4616
seisman wants to merge 26 commits into
mainfrom
pygmtlogo

Conversation

@seisman

@seisman seisman commented May 2, 2026

Copy link
Copy Markdown
Member

This PR tracks the implementation of the PyGMT logos in different versions.

Logo implementation status

Variant Colored + Light Colored + Dark Grayscale + Light Grayscale + Dark
Circular, no wordmark
Circular, horizontal wordmark
Circular, vertical wordmark
Hexagon, no wordmark
Hexagon, horizontal wordmark
Hexagon, vertical wordmark

Related PRs and issues

Hexagon shape

Pro

  • Seems to be quite popular (even for Python)

Contra

  • lost of context / connection to Earth and compass
  • difficult of implement based on fractions rather than on empircal factors
  • difficult to make to logo conistent across both shapes
  • 12 variants already for circle shape (color/bw, no/hor./vert. wordmark, light/dark), multiple tests with baseline images
  • longer code, difficult to maintain

Some important comments from #3849

Known issues

  • After plotting the logo, -X+w is expected to shift the plotting origin in the x-direction by logo width, but it actually shifts more than that. It's likely an issue with the image module.

…GMT logo (#3849)

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman seisman added this to the 0.19.0 milestone May 2, 2026
@seisman seisman added the feature Brand new feature label May 2, 2026
@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_pygmtlogo_design_circle-horizontal.png
added pygmt/tests/baseline/test_pygmtlogo_design_circle-vertical.png
added pygmt/tests/baseline/test_pygmtlogo_design_hexagon-horizontal.png
added pygmt/tests/baseline/test_pygmtlogo_design_hexagon-vertical.png
added pygmt/tests/baseline/test_pygmtlogo_wordmark_horizontal_circle.png
added pygmt/tests/baseline/test_pygmtlogo_wordmark_horizontal_hexagon.png
added pygmt/tests/baseline/test_pygmtlogo_wordmark_none_circle.png
added pygmt/tests/baseline/test_pygmtlogo_wordmark_none_hexagon.png
added pygmt/tests/baseline/test_pygmtlogo_wordmark_vertical_circle.png
added pygmt/tests/baseline/test_pygmtlogo_wordmark_vertical_hexagon.png

Image diff(s)

Details

Added images

  • test_pygmtlogo_design_circle-horizontal.png

  • test_pygmtlogo_design_circle-vertical.png

  • test_pygmtlogo_design_hexagon-horizontal.png

  • test_pygmtlogo_design_hexagon-vertical.png

  • test_pygmtlogo_wordmark_horizontal_circle.png

  • test_pygmtlogo_wordmark_horizontal_hexagon.png

  • test_pygmtlogo_wordmark_none_circle.png

  • test_pygmtlogo_wordmark_none_hexagon.png

  • test_pygmtlogo_wordmark_vertical_circle.png

  • test_pygmtlogo_wordmark_vertical_hexagon.png

Modified images

Path Old New

Report last updated at commit 3e00ddd

…_pygmtlogo_circle_no_wordmark (#4617)

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
…4634)

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman seisman added the needs review This PR has higher priority and needs review. label Jun 18, 2026
@seisman seisman marked this pull request as ready for review June 18, 2026 01:08
@yvonnefroehlich

yvonnefroehlich commented Jun 18, 2026

Copy link
Copy Markdown
Member

Unfortunately I needed more time to catch up with things after being back from the workshop as expected - but now finally back at the PyGMT logo. From roughly going through the changes made in the mean time, things look really good.

Two aspects for now:

(i) The color of the wordmark for the colored version, as mentioned in #4627 (comment):

pygmt_logo_wordmark_fontcolor_gmt_in_red

(ii) After removing the inner compass lines, the horizontal line of the letter G does not start anymore at the left side of letter M (sorry for the confusing description; hope the image make it clear):
pygmt_logo_letter_g_hor_line_length_compare

Comment thread pygmt/src/pygmtlogo.py Outdated
Comment thread pygmt/src/pygmtlogo.py
Comment on lines +66 to +67
"light": (color_light, blue, color_dark),
"dark": (color_dark, yellow, color_light),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"light": (color_light, blue, color_dark),
"dark": (color_dark, yellow, color_light),
"light": (color_light, blue, color_red),
"dark": (color_dark, yellow, color_red),

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the color choices, I feel the old version is better, because the GMT-red color makes the text “GMT” too visually heavy and eye-catching, drawing attention away from the logo symbol.

@seisman seisman deployed to pr-tests June 24, 2026 01:06 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Brand new feature needs review This PR has higher priority and needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants