[BUG FIX] Fix for dockerfile error #332
Open
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses cross-platform compatibility issues common when developing Docker images on Windows systems
FIX for: ERROR: failed to solve: process "/bin/sh -c chmod +x ./build_luisa.sh && ./build_luisa.sh ${PYTHON_VERSION}" did not complete successfully: exit code: 127
|
I should add, this relates to a current open issue #326 |
|
@skurtyyskirts I am wondering if I run dos2unix outside the Docker on the build_luisa.sh script, can we avoid the installation of dos2unix in the Docker? I don't have any Windows machine available for now so cannot test it quickly. |
|
Oh that's a good question, if anyone see's this ticket and is available to test it would be much appreciated, I'm away from the home pc for a bit :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows-style CRLF line endings in the build script causing compatibility issues in the Linux container. Added dos2unix package installation to handle Windows/Unix line ending conversion.