refactoring of element-wise updates #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solution supplies the updated value and the vector of jskeys to the
notify()
routine.This PR takes a more general approach and supplies a vector of pairs containing all objects (arrays or dicts) with their respective index. This makes it possible for users to write their own update functions that take into account, e.g. the index of the changed element.
Other changes:
methods()
call to avoid decrease of performance.This code could be transferred to Observables with only minor changes. I've commented an open issue to ask if they are interested.