Skip to content

fix(llm): count escalation payload_chars as characters, not bytes #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matedev01 merged 2 commits into from
Jul 24, 2026
Merged

fix(llm): count escalation payload_chars as characters, not bytes #852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdd3224
fix(llm): count escalation payload_chars as characters, not bytes
jeffrey701 Jul 24, 2026
400fcbf
Merge branch 'main' into fix/escalation-payload-chars
matedev01 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion crates/genie-core/src/llm/escalation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ pub struct EscalationPayloadSummary {
pub fn summarize_messages(messages: &[Message]) -> EscalationPayloadSummary {
EscalationPayloadSummary {
message_count: messages.len(),
payload_chars: messages.iter().map(|m| m.content.len()).sum(),
payload_chars: messages.iter().map(|m| m.content.chars().count()).sum(),
}
}

Expand Down Expand Up @@ -116,4 +116,15 @@ mod tests {
assert_eq!(summary.message_count, 2);
assert_eq!(summary.payload_chars, 6);
}

#[test]
fn summarize_counts_unicode_chars_not_bytes() {
// payload_chars feeds the escalation audit trail, so a multi-byte
// character (café is 4 chars, 5 bytes) must count as one char.
let messages = vec![Message {
role: "user".into(),
content: "café".into(),
}];
assert_eq!(summarize_messages(&messages).payload_chars, 4);
}
}
Loading