Refactor combat state handling in McpMod.StateBuilder - #36
Open
judgeou wants to merge 1 commit into
Open
Conversation
judgeou
commented
Mar 30, 2026
judgeou
commented
- Simplified the logic for serializing combat fields by removing unnecessary checks for combat state.
- Ensured that HP, max HP, and block values are always retrieved from the creature, regardless of combat status.
- Updated comments for clarity on the handling of combat-related data.
- Simplified the logic for serializing combat fields by removing unnecessary checks for combat state. - Ensured that HP, max HP, and block values are always retrieved from the creature, regardless of combat status. - Updated comments for clarity on the handling of combat-related data.
Author
|
@Gennadiyev Have you noticed that when you're not in combat, your HP is 0/0? |
Owner
Not... really...
|
Author
strange... |
Owner
Are you in multiplayer? |
Author
No, singleplayer, I have always conducted tests in a single-player environment. |
Gennadiyev
added
thinking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.