Skip to content

Fix combat play phase on STS2 v0.104 - #75

Draft
uvxdotdev wants to merge 1 commit into
Gennadiyev:mainfrom
uvxdotdev:uvx/fix-sts2-v104-combat-api
Draft

Fix combat play phase on STS2 v0.104#75
uvxdotdev wants to merge 1 commit into
Gennadiyev:mainfrom
uvxdotdev:uvx/fix-sts2-v104-combat-api

Conversation

@uvxdotdev

Copy link
Copy Markdown

Hi! This updates STS2MCP for the STS2 v0.104.0 combat API change where CombatManager.IsPlayPhase is no longer available.

What changed:

  • replace direct IsPlayPhase calls with a small helper based on combat state, player turn membership, and turn-ending/action-disabled flags
  • update target resolution to accept ICombatState
  • note v0.104.0 compatibility in the README

Validation:

  • dotnet build STS2_MCP.csproj -c Release -o out/STS2_MCP -p:STS2GameDir="$HOME/Library/Application Support/Steam/steamapps/common/Slay the Spire 2"
  • tested locally on macOS with STS2 v0.104.0 by reading combat state and playing through a combat via the REST API

@uvxdotdev
uvxdotdev force-pushed the uvx/fix-sts2-v104-combat-api branch from e5d6541 to 13484c1 Compare May 3, 2026 07:01
@uvxdotdev

Copy link
Copy Markdown
Author

Small note for review: I built and tested this against the current v0.104.0 DLL, where CombatManager.IsPlayPhase is gone. Would you prefer this patch to also preserve compatibility with older STS2 builds explicitly, or is targeting the current game version the right direction for this repo?

@Gennadiyev

Gennadiyev commented May 4, 2026

Copy link
Copy Markdown
Owner

Is targeting the current game version the right direction for this repo?

Of course.

I typically do not add features to support the beta branch - I don't have enough energy (pun xD) to maintain compatibility with a nightly release so 🙇 maybe I'll push this off until the changes are live.

Thanks for your work ⚡ When the API is actually removed this PR will be an immediate merge.

@uvxdotdev

Copy link
Copy Markdown
Author

Haha totally understandable, I like to play with the latest changes thats why I made it for myself.

@G07cha

G07cha commented Aug 1, 2026

Copy link
Copy Markdown

Seems like those changes are already covered in merged #123 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants