-
Notifications
You must be signed in to change notification settings - Fork 22
Draft: add MISIP-MIMS #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mslarae13
wants to merge
20
commits into
main
Choose a base branch
from
1001-add-misip-mims
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+563
−52
Open
Draft: add MISIP-MIMS #1002
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3b7a986
add isotope slot
mslarae13 21eee14
add isotopolog & iso label
mslarae13 d63c0b0
add gradient
mslarae13 0c2eb16
string, not text!
mslarae13 c84ed4d
add gradient pos density
mslarae13 cc4472e
yaml linting errors
turbomam 2592a7f
add remaining slots and class
mslarae13 09a0817
Merge branch '1001-add-misip-mims' of https://github.com/GenomicsStan…
mslarae13 5af3278
update class
mslarae13 b481cfa
lint error?
mslarae13 1a1b665
question
mslarae13 d65d04d
remove excess space
mslarae13 44292e6
move requirements to slot and off slot usage
mslarae13 7865c9a
update misip name
mslarae13 9878d25
clarify multivalued slots
mslarae13 429273f
dd MimsMisip + extension combinations
mslarae13 489ad27
add mims example
mslarae13 100cb74
comment lint error
mslarae13 5f3bc2b
fix indentation
sierra-moxon a4d4ea9
fix comment spaces
sierra-moxon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slot_uri: MIXS:###
These are missing from all my new slots. Do you know how these are made / assigned? Just sequential?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark asked in an issue in the issue tracker. Connect with Lynn for getting the identifier assignments details.
Maybe add a tool for identifying the next available ID or any gaps ? -- OBO ontologies have tools we could mimic