Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report recommended assertions when slot_usage says the slot is required #675

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

turbomam
Copy link
Member

@turbomam turbomam commented Oct 19, 2023

when a slot_usage already has required asserted
@turbomam turbomam requested a review from lschriml October 19, 2023 16:50
@turbomam turbomam marked this pull request as ready for review October 19, 2023 16:51
@turbomam turbomam changed the title report and optionally remove recommended when a slot_usage already has required asserted DO NOT MERGE YET. Report and optionally remove recommended when a slot_usage already has required asserted Oct 19, 2023
@turbomam turbomam marked this pull request as draft March 26, 2024 16:41
@turbomam
Copy link
Member Author

turbomam commented Apr 5, 2024

Here I wrote some one-off linting code in this schema repo.

I should have done that upstream in LinkML

I also have to decide whether the edits to the schema (removing recommended when required is already set) should be a manual edit, o r applied programatically

@turbomam turbomam requested review from cmungall and removed request for lschriml and mslarae13 April 5, 2024 22:08
@turbomam turbomam changed the title DO NOT MERGE YET. Report and optionally remove recommended when a slot_usage already has required asserted Report recommended assertion when a slot_usage make the slot required Oct 8, 2024
@turbomam turbomam changed the title Report recommended assertion when a slot_usage make the slot required Report recommended assertions when slot_usage says the slot is required Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant