-
Notifications
You must be signed in to change notification settings - Fork 22
current land use enum with URL safe characters #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
turbomam
wants to merge
3
commits into
main
Choose a base branch
from
969-cur_land_use-was-an-enum-before-linkml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+123
−17
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,126 @@ | |
nucleic acid sequence source: | ||
investigation: | ||
enums: | ||
CurLandUseEnum: | ||
permissible_values: | ||
badlands: | ||
cities: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly, meaning for cities – http://purl.obolibrary.org/obo/ENVO_00000856 |
||
conifers: | ||
fir: | ||
is_a: conifers | ||
pine: | ||
is_a: conifers | ||
spruce: | ||
is_a: conifers | ||
cypress: | ||
is_a: conifers | ||
crop trees: | ||
christmas trees: | ||
is_a: crop trees | ||
fruit: | ||
is_a: crop trees | ||
nursery trees: | ||
is_a: crop trees | ||
nuts: | ||
is_a: crop trees | ||
farmstead: | ||
gravel: | ||
hardwoods: | ||
aspen: | ||
is_a: hardwoods | ||
elm: | ||
is_a: hardwoods | ||
hickory: | ||
is_a: hardwoods | ||
oak: | ||
is_a: hardwoods | ||
hayland: | ||
horticultural plants: | ||
tulips: | ||
is_a: horticultural plants | ||
industrial areas: | ||
intermixed hardwood and conifers: | ||
marshlands: | ||
grass: | ||
is_a: marshlands | ||
rushes: | ||
is_a: marshlands | ||
sedges: | ||
is_a: marshlands | ||
meadows: | ||
alfalfa: | ||
is_a: meadows | ||
bromegrass: | ||
is_a: meadows | ||
fescue: | ||
is_a: meadows | ||
grasses: | ||
is_a: meadows | ||
timothy: | ||
is_a: meadows | ||
mines-quarries: | ||
mudflats: | ||
oil waste areas: | ||
pastureland: | ||
description: grasslands used for livestock grazing | ||
permanent snow or ice: | ||
rainforest: | ||
description: evergreen forest receiving greater than 406 cm annual rainfall | ||
rangeland: | ||
roads-railroads: | ||
rock: | ||
row crops: | ||
saline seeps: | ||
salt flats: | ||
sand: | ||
shrub crops: | ||
blueberries: | ||
is_a: shrub crops | ||
filberts: | ||
is_a: shrub crops | ||
nursery ornamentals: | ||
is_a: shrub crops | ||
shrub land: | ||
creosote bush: | ||
is_a: shrub land | ||
eucalyptus: | ||
is_a: shrub land | ||
mesquite: | ||
is_a: shrub land | ||
sage-brush: | ||
is_a: shrub land | ||
shrub oak: | ||
is_a: shrub land | ||
small grains: | ||
successional shrub land: | ||
blackberries: | ||
is_a: successional shrub land | ||
chokecherry: | ||
is_a: successional shrub land | ||
hazels: | ||
is_a: successional shrub land | ||
shrub dogwoods: | ||
is_a: successional shrub land | ||
sumacs: | ||
is_a: successional shrub land | ||
tree saplings: | ||
is_a: successional shrub land | ||
swamp: | ||
description: permanent or semi-permanent water body dominated by woody plants | ||
tropical: | ||
mangrove: | ||
is_a: tropical | ||
palms: | ||
is_a: tropical | ||
tundra: | ||
lichens: | ||
is_a: tundra | ||
mosses: | ||
is_a: tundra | ||
vegetable crops: | ||
vine crops: | ||
grapes: | ||
is_a: vine crops | ||
InsdcMissingValueEnum: | ||
description: Permissible values recommended by INSDC for reporting missing metadata values. | ||
comments: | ||
|
@@ -5419,7 +5539,7 @@ | |
interpolated: true | ||
partial_match: true | ||
climate_environment: | ||
deprecated: true, slot is inconsistently used and provides redundant information to other slots, https://github.com/GenomicsStandardsConsortium/mixs/issues/591 and https://github.com/microbiomedata/nmdc-schema/issues/586 | ||
deprecated: true, slot is inconsistently used and provides redundant information to other slots, https://github.com/GenomicsStandardsConsortium/mixs/issues/591 and https://github.com/microbiomedata/nmdc-schema/issues/586 | ||
description: Treatment involving an exposure to a particular climate; treatment | ||
regimen including how many times the treatment was repeated, how long each treatment | ||
lasted, and the start and end time of the entire treatment; can include multiple | ||
|
@@ -5732,28 +5852,14 @@ | |
slot_uri: MIXS:0001119 | ||
multivalued: true | ||
cur_land_use: | ||
annotations: | ||
Expected_value: enumeration | ||
description: Present state of sample site | ||
title: current land use | ||
examples: | ||
- value: conifers | ||
keywords: | ||
- land | ||
- use | ||
string_serialization: '[cities|farmstead|industrial areas|roads/railroads|rock|sand|gravel|mudflats|salt | ||
flats|badlands|permanent snow or ice|saline seeps|mines/quarries|oil waste areas|small | ||
grains|row crops|vegetable crops|horticultural plants (e.g. tulips)|marshlands | ||
(grass,sedges,rushes)|tundra (mosses,lichens)|rangeland|pastureland (grasslands | ||
used for livestock grazing)|hayland|meadows (grasses,alfalfa,fescue,bromegrass,timothy)|shrub | ||
land (e.g. mesquite,sage-brush,creosote bush,shrub oak,eucalyptus)|successional | ||
shrub land (tree saplings,hazels,sumacs,chokecherry,shrub dogwoods,blackberries)|shrub | ||
crops (blueberries,nursery ornamentals,filberts)|vine crops (grapes)|conifers | ||
(e.g. pine,spruce,fir,cypress)|hardwoods (e.g. oak,hickory,elm,aspen)|intermixed | ||
hardwood and conifers|tropical (e.g. mangrove,palms)|rainforest (evergreen forest | ||
receiving >406 cm annual rainfall)|swamp (permanent or semi-permanent water | ||
body dominated by woody plants)|crop trees (nuts,fruit,christmas trees,nursery | ||
trees)]' | ||
range: CurLandUseEnum | ||
slot_uri: MIXS:0001080 | ||
cur_vegetation: | ||
annotations: | ||
|
@@ -9720,7 +9826,7 @@ | |
slot_uri: MIXS:0000283 | ||
multivalued: true | ||
range: string | ||
deprecated: true, replace with MIXS:0000270 https://github.com/GenomicsStandardsConsortium/mixs/issues/743 | ||
deprecated: true, replace with MIXS:0000270 https://github.com/GenomicsStandardsConsortium/mixs/issues/743 | ||
nose_throat_disord: | ||
description: > | ||
Report any history of nose, mouth, teeth and/or throat disorders in the subject. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add meanings to some of these PV's?
For example, is this an appropriate meaning for the badlands PV? http://purl.obolibrary.org/obo/ENVO_00000127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good idea @sujaypatil96
@cmungall and I discussed it today. Chris suggested focusing our PV meaning efforts on
I don't think 2 is true here, and I think 1 might be very difficult to accomplish because the current land use PVs are a mixture of land uses (which might be in EnvO) and organisms that might be found on land being used in some way. The organism names are a mixture of singular and plural, and may have many to many mappings within NCBI taxonomy
So I am going to skip PV meaning sin the PR