Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use static registry key to check vcredist on x86 Windows installer #2474

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SpecterShell
Copy link

@SpecterShell SpecterShell commented Mar 18, 2024

Currently the x86 Windows installers rely on the registry key of the "Apps and Features" entry to check if the x86 version of VCRedist has been installed. However the registry key differs between each version of VCRedist, making the installer attempt to install VCRedist during installation when a newer version of VCRedist has been installed. This PR replaces the registry key with the static one and has been tested locally.

Related GitHub Actions runs with the fix: https://github.com/SpecterShell/geoda/actions/runs/8322035879

@lixun910
Copy link
Member

Thanks for your PR @SpecterShell ! C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants