Tooling & PHP Version Updates #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
MiniCodeMonkey
approved these changes
Sep 20, 2024
| <directory suffix=".php">src/</directory> | ||
| </whitelist> | ||
| </filter> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="vendor/autoload.php" backupGlobals="false" colors="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.3/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false"> |
There was a problem hiding this comment.
@sixlive Can this file be removed now, since we're using Pest?
There was a problem hiding this comment.
Pest uses PHPUnit under the hood so the config file is still used
| $response = $e instanceof RequestException && $e->hasResponse() ? $e->getResponse() : null; | ||
|
|
||
| $errorMessage = 'Error'; | ||
| $errorCode = 0; | ||
|
|
||
| if ($response) { | ||
| $json = @json_decode((string)$response->getBody()); | ||
| if ($response instanceof \Psr\Http\Message\ResponseInterface) { |
tests/ArchTest.php
Outdated
|
|
||
| describe('Custom relaxed preset', function (): void { | ||
| arch('No final classes') | ||
| ->expect('EchoLabs\Sparkle') |
There was a problem hiding this comment.
Should this namespace be updated to Geocodio?
There was a problem hiding this comment.
Good catch, copypasta
| { | ||
| "disabled": [], | ||
| "hooks": { | ||
| "pre-commit": [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overall this PR is prepping for release 2.0 with the following changes: