Minor changes to SDL.Version struct a new class #2
+131
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to aide in certain functions where some must meet a requirement.
|
I question this a year later |
|
You mean, you're not sure if the changes make sense any more? Or you question the review? |
|
I've only questioned it because it was left as a draft and not an actual pull request. For now, this looks good to me and is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've upgraded SDL.Version to accept conditional handling such as checking against specific versions of SDL. SdlAvailableAttribute class was created in hopes that it can aide in certain methods of checking whether the requirement is met. For example: SDL.Vulkan_LoadLibrary requires 2.0.6 as this function evidently is only available in that build of SDL. Eventually, I would like to adopt this to every function available to the end-user as a safety net. I wouldn't commit this just yet as there's not enough to make it worth while.