-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computing WO from S2 ARD #1213
base: develop
Are you sure you want to change the base?
Computing WO from S2 ARD #1213
Conversation
abandoned
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hey @Yukienip do you have more files in here than the ones you have updated? you may want to look at doing this one from a fresh branch and pulling your updates on a fresh checkout of develop? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Yukienip! This is an incredible piece of work, and something we definitely want to preserve and make accessible for future reference. 🚀 Thinking about the range of content this includes, I do think that the public-facing develop
/stable
branches of DEA Notebooks may not be quite the right place for it as these are primarily for self-contained tutorial-style content: this is more of a research output with supplementary data and sample outputs (similar to some material we used to include in the Scientific_workflows
folder in this repo that we removed from develop
last year).
I think this content is better suited to stay on a discrete branch (not merged into develop
) where it will still be accessible and available, but sit as an independent set of content. So it doesn't get lost, we can set up some branch protection rules to lock it down, and also have a think about a nice place where we can link to this material so it's also discoverable. There's some precedents for this kind of "research"-style content on the branches below:
- https://github.com/GeoscienceAustralia/dea-notebooks/tree/scientific_workflows_archive
- https://github.com/GeoscienceAustralia/dea-notebooks/tree/subpixel_waterlines
- https://github.com/GeoscienceAustralia/dea-notebooks/tree/coastal-waterbodies
Let me know what you think! (Another option could be to try and simplify the content down to a single stand-alone notebook, but I'd worry we'd lose too much useful content if we did that)
Proposed changes
New notebook to demonstrate applying WO classifier to S2 imagery. Provides options for x-y input and custom bounding box. Chosen area for demonstration is affected by cloud masking error, and solutions are explored in the following notebook (Name TBC, currently Incorporating_Fmask_ARD)
Closes issues (optional)
Checklist
(Replace
[ ]
with[x]
to check off)Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).NCI
andDEA Sandbox
(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment only
line below the notebook title to reflect the environments the notebook is compatible with