Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folium map #746

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Folium map #746

wants to merge 3 commits into from

Conversation

Gabzgit
Copy link
Collaborator

@Gabzgit Gabzgit commented Dec 17, 2020

Proposed changes

Instead of having one classified map and one rgb map side-by-side, overlay them in folium.
The rgb is still not displaying correctly.

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@s-m-t-c
Copy link
Collaborator

s-m-t-c commented Jan 20, 2021

Currently the folium map designed to replace the two image plot is currently displaying in solid black and white over the basemap. The goal is to have a single colour for the value 1 and transparency for the value 0 for the classified data over the RGB image.

Note that is considerably slower to load the folium map (8 seconds) compared to the images (1.5 seconds). This is probably irritating enough that I would consider sticking with the image method if it remains that slow but it would be neat to get the folium overlay working for the sake of it.

@s-m-t-c s-m-t-c requested a review from robbibt March 24, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants