Update the whole leaflet ecosystem #1258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabhub
approved these changes
Oct 1, 2024
| @@ -18,7 +18,7 @@ const MapContainer: React.FC<Props> = ({ children, whenCreated, hasZoomControl = | |||
| center={mapConfig.searchMapCenter as [number, number]} | |||
| zoom={mapConfig.searchMapZoom} | |||
| maxZoom={mapConfig.maximumZoomLevel} | |||
| whenCreated={whenCreated} | |||
| ref={whenCreated} | |||
There was a problem hiding this comment.
Isn't it kinda weird having a function as ref props?
There was a problem hiding this comment.
Yep, since Leaflet 1.9 (I'm not sure of the version), the whenCreated prop has been replaced by whenReady but it's not really the same callback function.
When React-leaflet shipped version 4, the release note explicitly wrote:
Removed
whenCreatedproperty from theMapContainercomponent (arefcallback can be used instead).
Comment on lines
+5
to
+15
| import MapContainer from 'components/Map/SearchMap/MapContainer'; | ||
| import MoveHandler from 'components/Map/SearchMap/MoveHandler'; | ||
| import SearchMapChildrens from 'components/Map/SearchMap/SearchMapChildrens'; | ||
| import { ArrowLeft } from 'components/Icons/ArrowLeft'; | ||
| import { useTileLayer } from 'hooks/useTileLayer'; | ||
| import { BackButton } from '../components/BackButton'; | ||
| import { FilterButton } from '../components/FilterButton'; | ||
| import { ResetView } from '../components/ResetView'; | ||
| import TileLayerManager from '../components/TileLayerManager'; | ||
| import FullscreenControl from '../components/FullScreenControl'; | ||
| import LocateControl from '../components/LocateControl'; | ||
| import { BackButton } from 'components/Map/components/BackButton'; | ||
| import { FilterButton } from 'components/Map/components/FilterButton'; | ||
| import { ResetView } from 'components/Map/components/ResetView'; | ||
| import TileLayerManager from 'components/Map/components/TileLayerManager'; | ||
| import FullscreenControl from 'components/Map/components/FullScreenControl'; | ||
| import LocateControl from 'components/Map/components/LocateControl'; |
There was a problem hiding this comment.
Switching from relative paths to aliased path do not seams directly related to "Leaflet ecosystem".
Maybe should it have been done in a another dedicated PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1219