Skip to content

fix invalid rocrate creation #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −7
Open

fix invalid rocrate creation #38

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8adc938
using of rocrate context for that properties results in an invalid ro…
Dec 12, 2024
179248b
Merge branch 'German-BioImaging:main' into main
sukunis Dec 12, 2024
9b5243c
adapt context
sukunis Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/omero_rdf/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,13 @@ def serialize_graph(self):
{
"@id": "./",
"@type": "Dataset",
"rocrate:license": "https://creativecommons.org/licenses/by/4.0/",
Copy link
Member

@joshmoore joshmoore Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop the context statement about then, @sukunis?

Copy link
Member Author

@sukunis sukunis Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that adaption of context entity is needed

"license": "https://creativecommons.org/licenses/by/4.0/",
},
{
"@id": "ro-crate-metadata.json",
"@type": "CreativeWork",
"rocrate:conformsTo": {"@id": "https://w3id.org/ro/crate/1.1"},
"rocrate:about": {"@id": "./"},
"conformsTo": {"@id": "https://w3id.org/ro/crate/1.1"},
"about": {"@id": "./"},
},
]
return json.dumps(j, indent=4)
Expand Down
Loading