fix: reject promise if peer connection observer is not found (#2)

* fix: promise reject if peer connection observer is not found * 118.1.2-alpha.1 * fix final values * 118.1.2-alpha.2
GetStream · Oct 10, 2024 · 737b20e · 737b20e
1 parent d249142
commit 737b20e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java b/android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java
@@ -966,7 +966,7 @@ public void peerConnectionSetConfiguration(ReadableMap configuration, int id) {
     public void peerConnectionCreateOffer(int id, ReadableMap options, Promise promise) {
         ThreadUtils.runOnExecutor(() -> {
             PeerConnectionObserver pco = mPeerConnectionObservers.get(id);
-            PeerConnection peerConnection = pco.getPeerConnection();
+            PeerConnection peerConnection = pco == null ? null : pco.getPeerConnection();
 
             if (peerConnection == null) {
                 Log.d(TAG, "peerConnectionCreateOffer() peerConnection is null");
@@ -1128,7 +1128,7 @@ public void onSetFailure(String s) {
     public void peerConnectionSetRemoteDescription(int id, ReadableMap desc, Promise promise) {
         ThreadUtils.runOnExecutor(() -> {
             PeerConnectionObserver pco = mPeerConnectionObservers.get(id);
-            PeerConnection peerConnection = pco.getPeerConnection();
+            PeerConnection peerConnection = pco == null ? null : pco.getPeerConnection();
 
             if (peerConnection == null) {
                 Log.d(TAG, "peerConnectionSetRemoteDescription() peerConnection is null");

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@stream-io/react-native-webrtc",
-  "version": "118.1.1",
+  "version": "118.1.2-alpha.2",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/GetStream/react-native-webrtc.git"