Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i236] fix message list blinking #5150

Merged
merged 8 commits into from
Jan 18, 2024
Merged

[i236] fix message list blinking #5150

merged 8 commits into from
Jan 18, 2024

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Jan 17, 2024 •
edited
Loading

🎯 Goal

Closes:

Related PR:

🛠 Implementation details

RootCause:
We were recreating and setting the MessageListAdapter on each channel object emission

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review January 17, 2024 23:16
@kanat kanat requested a review from a team as a code owner January 17, 2024 23:16
@kanat kanat changed the title Blinking message list [i236] fix message list blinking Jan 17, 2024
JcMinarro
JcMinarro reviewed Jan 18, 2024
View reviewed changes
@kanat kanat force-pushed the blinking-message-list branch from e3f7ae0 to 1455a76 Compare January 18, 2024 15:08
@kanat kanat requested a review from JcMinarro January 18, 2024 15:09
@JcMinarro JcMinarro enabled auto-merge (rebase) January 18, 2024 15:28
@JcMinarro JcMinarro merged commit 0973459 into develop Jan 18, 2024
7 checks passed
@JcMinarro JcMinarro deleted the blinking-message-list branch January 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @JcMinarro