Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Make snapshot tests great again #5486

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

testableapple
Copy link
Collaborator

@testableapple testableapple commented Nov 22, 2024

Resolves https://stream-io.atlassian.net/browse/PBE-5883

🎯 Goal

  • Fix the Snapshot Testing workflow on GitHub Actions

⚠️ Known issues

  • The workflow is disabled on PRs because sometimes remote images are not shown on the screenshots. We should mock the images or use local ones. More details can be found here.

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

gif

@testableapple testableapple force-pushed the ci/make-snapshot-tests-green-again branch 2 times, most recently from 027f561 to 99cd278 Compare November 25, 2024 18:13
@testableapple testableapple marked this pull request as ready for review November 25, 2024 18:19
@testableapple testableapple requested a review from a team as a code owner November 25, 2024 18:19
@testableapple testableapple force-pushed the ci/make-snapshot-tests-green-again branch from 8512552 to 06b0ae3 Compare November 25, 2024 20:04
@testableapple testableapple merged commit 0a15c2e into develop Nov 26, 2024
9 checks passed
@testableapple testableapple deleted the ci/make-snapshot-tests-green-again branch November 26, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants