Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-3] Threads V2 - XML #5491

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

[AND-3] Threads V2 - XML #5491

wants to merge 29 commits into from

Conversation

VelikovPetar
Copy link
Contributor

@VelikovPetar VelikovPetar commented Nov 27, 2024 •
edited
Loading

🎯 Goal

Implement the Threads V2 feature for the ui-components SDK.
Linear: https://linear.app/stream/issue/AND-3/threads-v2-android-xml

🛠 Implementation details

  • Implement new ThreadsViewModelFactory and ThreadListViewModel using the the already existing ThreadListController
  • Implement new ThreadListView component for rendering the thread list
  • Implement ThreadListViewModel.bindView method for easy link between the ViewModel and the ThreadList
  • Implement customization options for the ThreadListView (view attributes, theme or StyleTransformer)
  • Add Threads tab in the sample app

🎨 UI Changes

sample-threads-tab

🧪 Testing

  1. Open XML SDK sample app
  2. Open 'Threads' tab

@VelikovPetar VelikovPetar marked this pull request as ready for review November 27, 2024 13:22
@VelikovPetar VelikovPetar requested a review from a team as a code owner November 27, 2024 13:22
@JcMinarro JcMinarro enabled auto-merge (squash) December 5, 2024 13:10
@JcMinarro JcMinarro force-pushed the feature/threads_v2_xml branch from a163915 to 986dad2 Compare December 5, 2024 13:10
@JcMinarro JcMinarro disabled auto-merge December 5, 2024 13:11
@testableapple testableapple added QAed and removed QAing labels Dec 9, 2024
testableapple
testableapple requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@testableapple testableapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently discussing issues in slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testableapple testableapple testableapple requested changes

@JcMinarro JcMinarro JcMinarro approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
QAed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VelikovPetar @JcMinarro @testableapple